Builder wget-solaris10-sparc Build #548

Results:

Failed shell shell_1 shell_2 shell_3

SourceStamp:

BuildSlave:

Reason:

The SingleBranchScheduler scheduler named 'schedule-wget-solaris10-sparc' triggered this build

Steps and Logfiles:

1. git update ( 6 secs )
   1. stdio
2. shell 'bash bootstrap' failed ( 17 secs )
   1. stdio
3. shell_1 './configure' failed ( 0 secs )
   1. stdio
   2. src/config.h
   3. config.log
4. shell_2 'gmake' failed ( 0 secs )
   1. stdio
5. shell_3 'gmake check' failed ( 0 secs )
   1. stdio
   2. tests-unit-tests.log
   3. tests-test-suite.log
   4. testenv-test-suite.log

Build Properties:

Forced Build Properties:

Responsible Users:

1. Darshit Shah

   darnirohnoyoudont@gnu.org
2. Sam James

   samohnoyoudont@gentoo.org

Timing:

All Changes:

:

1. Change #213732

   Category	wget
   Changed by	Darshit Shah <darnirohnoyoudont@gnu.org>
   Changed at	Sun 10 Nov 2024 14:57:15
   Repository	https://gitlab.com/gnuwget/wget.git
   Project	wget
   Branch	master
   Revision	1f7e094899647a52cf9157f3a6600ae801f7a98b

   Comments

   src/utils.h: Include wget.h before stdlib.h
   * src/utils.h: wget.h includes config.h which should be included before
       any other header files. So swap the order of includes

   Changed files

   • src/utils.h

2. Change #213733

   Category	wget
   Changed by	Sam James <samohnoyoudont@gentoo.org>
   Changed at	Sun 10 Nov 2024 15:36:43
   Repository	https://gitlab.com/gnuwget/wget.git
   Project	wget
   Branch	master
   Revision	1bc591564d28ed11174e75e6cd8fed220c410ce1

   Comments

   init: fix -Warray-bounds in setval_internal_tilde
   >= GCC 12 reports an instance of -Warray-bounds in setval_internal_tilde
   with the default -DNDEBUG:
   ```
   In function ‘setval_internal_tilde’,
       inlined from ‘run_wgetrc’ at init.c:710:16:
   init.c:940:17: error: array subscript [0, 167] is outside array bounds of ‘const struct <anonymous>[168]’ [-Werror=array-bounds=]
     940 |   if (((commands[comind].action == cmd_file) ||
         |         ~~~~~~~~^~~~~~~~
   init.c: In function ‘run_wgetrc’:
   init.c:135:3: note: while referencing ‘commands’
     135 | } commands[] = {
         |   ^~~~~~~~
   ```
   
   setval_internal_tilde calls setval_internal and stores the result in ret;
   setval_internal *does* check for if comind is out-of-bounds, but we only
   check that *after* dereferencing commands[comind]. Swap the order in the
   if() to fix that so we only dereference if we know it's safe.
   
   ChangeLog:
   
   	* src/init.c (setval_internal_tilde): Check 'ret' earlier.
   
   Copyright-paperwork-exempt: Yes

   Changed files

   • src/init.c