Builder wget-solaris10-i386 Build #539
Results:
Failed shell shell_1 shell_2 shell_3
SourceStamp:
| Project | wget |
| Repository | https://gitlab.com/gnuwget/wget.git |
| Branch | master |
| Revision | 1bc591564d28ed11174e75e6cd8fed220c410ce1 |
| Got Revision | 1bc591564d28ed11174e75e6cd8fed220c410ce1 |
| Changes | 2 changes |
BuildSlave:
unstable10xReason:
The SingleBranchScheduler scheduler named 'schedule-wget-solaris10-i386' triggered this build
Steps and Logfiles:
Build Properties:
| Name | Value | Source |
|---|---|---|
| branch | master | Build |
| builddir | /export/home/buildbot/slave/wget-solaris10-i386 | slave |
| buildername | wget-solaris10-i386 | Builder |
| buildnumber | 539 | Build |
| codebase | Build | |
| got_revision | 1bc591564d28ed11174e75e6cd8fed220c410ce1 | Git |
| project | wget | Build |
| repository | https://gitlab.com/gnuwget/wget.git | Build |
| revision | 1bc591564d28ed11174e75e6cd8fed220c410ce1 | Build |
| scheduler | schedule-wget-solaris10-i386 | Scheduler |
| slavename | unstable10x | BuildSlave |
| workdir | /export/home/buildbot/slave/wget-solaris10-i386 | slave (deprecated) |
Forced Build Properties:
| Name | Label | Value |
|---|
Responsible Users:
- Darshit Shahdarnir@gnu.org
- Sam Jamessam@gentoo.org
Timing:
| Start | Sun Nov 10 15:54:51 2024 |
| End | Sun Nov 10 15:55:52 2024 |
| Elapsed | 1 mins, 0 secs |
All Changes:
:
Change #213732
Category wget Changed by Darshit Shah <darnir@gnu.org> Changed at Sun 10 Nov 2024 14:57:15 Repository https://gitlab.com/gnuwget/wget.git Project wget Branch master Revision 1f7e094899647a52cf9157f3a6600ae801f7a98b Comments
src/utils.h: Include wget.h before stdlib.h * src/utils.h: wget.h includes config.h which should be included before any other header files. So swap the order of includesChanged files
- src/utils.h
Change #213733
Category wget Changed by Sam James <sam@gentoo.org> Changed at Sun 10 Nov 2024 15:36:43 Repository https://gitlab.com/gnuwget/wget.git Project wget Branch master Revision 1bc591564d28ed11174e75e6cd8fed220c410ce1 Comments
init: fix -Warray-bounds in setval_internal_tilde >= GCC 12 reports an instance of -Warray-bounds in setval_internal_tilde with the default -DNDEBUG: ``` In function ‘setval_internal_tilde’, inlined from ‘run_wgetrc’ at init.c:710:16: init.c:940:17: error: array subscript [0, 167] is outside array bounds of ‘const struct <anonymous>[168]’ [-Werror=array-bounds=] 940 | if (((commands[comind].action == cmd_file) || | ~~~~~~~~^~~~~~~~ init.c: In function ‘run_wgetrc’: init.c:135:3: note: while referencing ‘commands’ 135 | } commands[] = { | ^~~~~~~~ ``` setval_internal_tilde calls setval_internal and stores the result in ret; setval_internal *does* check for if comind is out-of-bounds, but we only check that *after* dereferencing commands[comind]. Swap the order in the if() to fix that so we only dereference if we know it's safe. ChangeLog: * src/init.c (setval_internal_tilde): Check 'ret' earlier. Copyright-paperwork-exempt: YesChanged files
- src/init.c