Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder gtar-solaris10-i386 Build #255

Results:

Failed shell shell_1 shell_2 shell_3

SourceStamp:

Projectgtar
Repositorygit://git.savannah.gnu.org/tar.git
Branchmaster
Revision812a49419a8866fbc4a01c51cfb85a5af006abb4
Got Revision812a49419a8866fbc4a01c51cfb85a5af006abb4
Changes23 changes

BuildSlave:

unstable10x

Reason:

The SingleBranchScheduler scheduler named 'schedule-gtar-solaris10-i386' triggered this build

Steps and Logfiles:

  1. git update ( 4 secs )
    1. stdio
  2. shell '/opt/csw/bin/bash bootstrap' failed ( 39 secs )
    1. stdio
  3. shell_1 './configure' failed ( 0 secs )
    1. stdio
  4. shell_2 'gmake' failed ( 0 secs )
    1. stdio
  5. shell_3 'gmake check' failed ( 0 secs )
    1. stdio
    2. testsuite.log

Build Properties:

NameValueSource
branch master Build
builddir /export/home/buildbot/slave/gtar-solaris10-i386 slave
buildername gtar-solaris10-i386 Builder
buildnumber 255 Build
codebase Build
got_revision 812a49419a8866fbc4a01c51cfb85a5af006abb4 Git
project gtar Build
repository git://git.savannah.gnu.org/tar.git Build
revision 812a49419a8866fbc4a01c51cfb85a5af006abb4 Build
scheduler schedule-gtar-solaris10-i386 Scheduler
slavename unstable10x BuildSlave
workdir /export/home/buildbot/slave/gtar-solaris10-i386 slave (deprecated)

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. Paul Eggert

Timing:

StartThu Aug 15 08:29:35 2024
EndThu Aug 15 08:30:20 2024
Elapsed44 secs

All Changes:

:

  1. Change #204648

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:45
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision 4642cd04edbd57414e004920fa4976d9f3be6206

    Comments

    Avoid strtoul
This is part of the general trend to prefer signed integer types,
to allow better runtime checking with -fsanitize=undefined etc.
* gnulib.modules: Remove strtoul.  Add xstrtoimax.
* src/checkpoint.c (checkpoint, format_checkpoint_string):
* src/system.c (sys_exec_checkpoint_script):
* src/tar.c (checkpoint_option):
Use intmax_t, not unsigned, for checkpoint numbers.
All uses changed.
* src/checkpoint.c (checkpoint_compile_action): Don’t assume
time_t == unsigned long.  Treat overflows as TYPE_MAXIMUM (time_t),
essentially infinity.
* src/tar.c (tar_sparse_major, tar_sparse_minor):
* src/tar.h (struct tar_stat_info):
Use intmax_t, not unsigned, for sparse major and minor.
All uses changed.
* src/tar.c (parse_opt):
Don’t mishandle multiple specifications of sparse major and minor.
* src/transform.c (struct transform):
Use idx_t, not unsigned, for match_number.  All uses changed.
(parse_transform_expr): Don’t mishandle large match numbers
by wrapping them around.

    Changed files

    • gnulib.modules
    • src/checkpoint.c
    • src/common.h
    • src/system.c
    • src/tar.c
    • src/tar.h
    • src/transform.c
    • src/xheader.c

  2. Change #204649

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:45
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision eb9bb9bf8049522230a0654c3f32e6373b945254

    Comments

    Default to GNU/Linux dev_t etc
* configure.ac (dev_t, ino_t, major_t, minor_t):
Default to GNU/Linux types.  This shouldn’t affect behavior;
it’s just a cleanup.

    Changed files

    • configure.ac

  3. Change #204650

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision 3ffe2eb0738504aabee0d3b4d0c03e01739b9d6c

    Comments

    Handle enormous record sizes better
Formerly the code could misbehave when the user specified a record
size greater than min (INT_MAX * 512 + 511, PTRDIFF_MAX, SSIZE_MAX).
* src/delete.c (new_blocks, delete_archive_members):
* src/system.c (sys_exec_info_script):
* src/tar.c (blocking_factor, record_size):
Don’t limit blocking factor to INT_MAX.
Prefer signed type for record_size.
Do not exceed IDX_MAX or SSIZE_MAX for record_size;
the SSIZE_MAX limit is needed so that ‘read’ and ‘write’
calls behave sensibly.

    Changed files

    • src/buffer.c
    • src/common.h
    • src/delete.c
    • src/system.c
    • src/tar.c

  4. Change #204651

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision d1e72a536f26188230a147d948b9057714fd0b6b

    Comments

    Prefer stoint to strtoul and variants
When parsing numbers prefer using strtosysint (renamed stoint)
to using strtoul and its variants.
This is simpler and faster and likely more reliable than
relying on quirks of the system strtoul etc,
and it standardizes how tar deals with parsing integers.
Among other things, the C standard and POSIX don’t specify
what strtol does to errno when conversions cannot be performed,
and it requires strtoul to support "-" before unsigned numbers.
* gnulib.modules (strtoimax, strtol, strtoumax, xstrtoimax):
Remove.
* src/checkpoint.c (checkpoint_compile_action, getwidth)
(format_checkpoint_string):
* src/incremen.c (read_incr_db_01, read_num)
* src/map.c (parse_id):
* src/misc.c (decode_timespec):
* src/sparse.c (decode_num):
* src/tar.c (parse_owner_group, parse_opt):
* src/transform.c (parse_transform_expr):
* src/xheader.c (decode_record, decode_signed_num)
(sparse_map_decoder):
Prefer stoint to strtol etc.
Don’t rely on errno == EINVAL as the standards don’t guarantee it.
* src/checkpoint.c (getwidth, format_checkpoint_string):
Check for invalid string suffix.
* src/checkpoint.c (getwidth):
Return intmax_t, not long.  All callers changed.
* src/incremen.c (read_directory_file):
It’s just a one-digit number, so just subtract '0'.
* src/map.c (parse_id): Return bool not int.  All callers changed.
* src/misc.c (stoint): Rename from strtosysint, and add
a bool * argument for reporting overflow.  All callers changed.
(decode_timespec): Simplify by using ckd_sub rather than
checking for overflow by hand.
* src/tar.c (incremental_level): Now signed char to
emphasize that it can be only -1, 0, 1.  All uses changed.
* src/xheader.c (decode_record): Avoid giant diagnostics.

    Changed files

    • gnulib.modules
    • src/checkpoint.c
    • src/common.h
    • src/incremen.c
    • src/map.c
    • src/misc.c
    • src/sparse.c
    • src/tar.c
    • src/transform.c
    • src/xheader.c

  5. Change #204652

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision 88c2aa1616aeaea8167e577b76468b9994f6391e

    Comments

    Fix minor integer overflow in xsparse.c
* scripts/xsparse.c (read_xheader):
Don’t assume size_t fits in unsigned.
Make the version numbers off_t, not just unsigned.

    Changed files

    • scripts/xsparse.c

  6. Change #204653

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision b3992e4ef89a3ca271c62779c5f59a0e5cf34cf9

    Comments

    Prefer signed types in blocking_read etc
* src/compare.c (process_noop, process_rawdata):
Return bool, not int.
* src/compare.c (process_noop, process_rawdata):
* src/create.c (dump_regular_file):
* src/extract.c (extract_file):
* src/misc.c (blocking_read, blocking_write):
* src/sparse.c (sparse_scan_file_raw, sparse_extract_region):
Prefer signed types like idx_t to unsigned ones like size_t.
(sparse_scan_file_raw): Diagnose read errors.

    Changed files

    • src/common.h
    • src/compare.c
    • src/create.c
    • src/extract.c
    • src/misc.c
    • src/sparse.c

  7. Change #204654

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision 9b69d17e24ea6b4a243d8b833ef41a0653b33eda

    Comments

    In short_read, use %td not %lu
* src/buffer.c (short_read): Don’t assume sizes fit
in unsigned long.

    Changed files

    • src/buffer.c

  8. Change #204655

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision 09aec02e3209e39fd22635d0be8874a34d70cff8

    Comments

    Use intmax_t, not size_t, for input line numbers
This works better on platforms where SIZE_MAX < OFF_MAX.
* src/common.h (struct common locus):
* src/names.c (struct name_elt):
Use intmax_t for line numbers.  All uses changed.

    Changed files

    • src/common.h
    • src/names.c
    • src/tar.c

  9. Change #204656

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision ef290cb171ca4d37eb57957f1eac888799ac04dd

    Comments

    Use idx_t, not size_t, for xattr value lengths.
* src/tar.h (struct xattr_map):
* src/xattrs.c (xattr_map_add): Prefer idx_t to size_t.  All uses
changed.

    Changed files

    • src/common.h
    • src/tar.h
    • src/xattrs.c

  10. Change #204657

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision 95ebde430314729ca898eef2b6e314201dde1f06

    Comments

    Simplify make_directory via xizalloc
* src/incremen.c (make_directory): Simplify by using
xizalloc instead of explicit initialization.

    Changed files

    • src/incremen.c

  11. Change #204658

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision e137c142851c249faf01c458884b8db8d9d76c08

    Comments

    Prefer signed integer in struct directory
* src/incremen.c (struct directory):
Prefer int to unsigned where either will do.

    Changed files

    • src/incremen.c

  12. Change #204659

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision 5ab90d6c96670a788779caafeee2cfc353d41ddf

    Comments

    Support >UINT_MAX lines in map files
* src/map.c (parse_id, map_read): Prefer intmax_t to unsigned
for line numbers.

    Changed files

    • src/map.c

  13. Change #204660

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision 1521d3dae01f91606c639eb745ea565ef723e38d

    Comments

    Avoid casts in tar_checksum
* src/list.c (tar_checksum, from_header):
Recode to avoid casts.

    Changed files

    • src/list.c

  14. Change #204661

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision 18dadeffc03d9b5ad9773b634f7dd387a198ace0

    Comments

    Don’t assume pid fits in unsigned long
* src/system.c (sys_wait_command): Convert pid_t to intmax_t,
not to unsigned long.

    Changed files

    • src/system.c

  15. Change #204662

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision c9a3abcbe7f1a7130c032d5b1a071ef40ebf0eba

    Comments

    Prefer signed to unsigned when decoding options
* src/tar.c (assert_format, decode_options):
Prefer signed to unsigned integers.
(optloc_save): Prefer enum to unsigned integer.
Simplify allocation.
(decode_options): No need to call ngettext for a value known
to be plenty large.

    Changed files

    • src/tar.c

  16. Change #204663

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision b201a3742162adcb2cf1e9618c4c4f4db0d239ae

    Comments

    Remove cast from from_header
* src/list.c (from_header): Reword to avoid a cast
to unsigned char.

    Changed files

    • src/list.c

  17. Change #204664

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision 43231ae554d0dacbcc32e2d0fe574c9d0e183258

    Comments

    Avoid need for base64_init and extra table
Simplify the code by assuming C99 initializers.
* src/list.c (base_64_digits): Remove.
(base64_map): Now a constant.  Now has its (old value + 1) % 65,
as that’s the only easy portable way to do it with a static
initializer (even on platforms where CHAR_BIT != 8); all uses changed.
(base64_init): Remove; only use removed.
(from_header): Adjust to new values in base64_map.

* src/list.c (base_64_digits): Remove; no longer needed.
(base64_map): Now const, initialized statically, and with
invalid entries being 0 not 64, and with valid entries
being 1 greater than before.

    Changed files

    • src/list.c

  18. Change #204665

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision 15c6010c325d9d4d9a1fa814400c8bb1fdd5e45a

    Comments

    Use intmax_t for read_incr_db_01 line numbers
* src/incremen.c (read_incr_db_01): Don’t assume line numbers
are less than LONG_MAX.

    Changed files

    • src/incremen.c

  19. Change #204666

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision b596676c78f96c49fccff98cbc7c90d528de69ff

    Comments

    Use idx_t for write_fatal_details size
* src/buffer.c (write_fatal_details): Prefer idx_t to size_t
for object size.

    Changed files

    • src/buffer.c

  20. Change #204667

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision ab7a14bd92242664856c555479dcbf03d9f9cd47

    Comments

    Add verror module
* gnulib.modules: Add verror; paxlib will need this.

    Changed files

    • gnulib.modules

  21. Change #204668

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision 6bc4c4bf96704fe3c016865fb71d9cc79c458c86

    Comments

    Fix minor diagnostic discrepancies in incrementals
* src/incremen.c (read_directory_file, get_gnu_dumpdir):
Be more consistent about fatal errors.

    Changed files

    • src/incremen.c

  22. Change #204669

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision 541f3bc374d3f10a88c51efa1ab511bf8ea4cd98

    Comments

    Fix duplicate write_error_details decl
* src/common.h (write_error_details): Remove decl
that belongs to paxutils.

    Changed files

    • src/common.h

  23. Change #204670

    Category gtar
    Changed by Paul Eggert <eggertohnoyoudont@cs.ucla.edu>
    Changed at Thu 15 Aug 2024 08:25:46
    Repository git://git.savannah.gnu.org/tar.git
    Project gtar
    Branch master
    Revision 812a49419a8866fbc4a01c51cfb85a5af006abb4

    Comments

    build: update gnulib and paxutils submodules to latest

    Changed files

    • gnulib
    • paxutils
BuildBot (0.8.14) working for the OpenCSW Buildbot project.
Page built: Sun 02 Nov 2025 19:15:39 (CET)