Builder curl-unthreaded-solaris10-i386 Build #15963

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

The SingleBranchScheduler scheduler named 'schedule-curl-unthreaded-solaris10-i386' triggered this build

Steps and Logfiles:

1. git update ( 8 secs )
   1. stdio
2. Runtest './tests/testcurl.pl --nogitpull ...' ( 2 mins, 13 secs )
   1. stdio
   2. resultlog
3. Mail result 'cat resultlog ...' ( 0 secs )
   1. stdio

Build Properties:

Forced Build Properties:

Responsible Users:

1. Viktor Szakats

   commitohnoyoudont@vsz.me
2. x2018

   xkernel.wangohnoyoudont@foxmail.com

Timing:

All Changes:

:

1. Change #249009

   Category	curl
   Changed by	Viktor Szakats <commitohnoyoudont@vsz.me>
   Changed at	Sun 16 Nov 2025 23:28:44
   Repository	https://github.com/curl/curl.git
   Project	curl
   Branch	master
   Revision	c07a7f6bf82f8f9aa59d189573378e494439164a

   Comments

   runtests: detect bad libssh differently for test 1459 (fixing CircleCI libssh job)
   test 1459 "SFTP with corrupted known_hosts" was seen failing in the past.
   To fix it, the test was automatically disabled when detecting libssh
   0.9.3 or older, as in the curl CircleCI job, running on Ubuntu 20.04.
   This work for a long time, until bumping the CircleCI runner to Ubuntu
   22.04 (to have OpenSSL 3), where the test was running again, and failing
   with the isssue seen in the past.
   
   - Test skipped with Ubuntu 20.04 (libssh 0.9.3):
     https://app.circleci.com/pipelines/github/curl/curl/16445/workflows/7f198763-e0b0-4037-9245-4c4b40ab8726/jobs/155164
   - Failure seen with Ubuntu 22.04 (libssh 0.9.6):
     https://app.circleci.com/pipelines/github/curl/curl/16452/workflows/b817a808-0fd4-40b0-8eb0-d064926efe12/jobs/155206?invite=true#step-107-211709_45
   - Failure seen with Ubuntu 24.04 (libssh 0.10.6):
     https://app.circleci.com/pipelines/github/curl/curl/16455/workflows/86c631f1-3c5f-4438-b398-3df2bdab5d20/jobs/155218
   
   Turns out the issue issue isn't libssh 0.9.3 itself, but
   a CircleCI-specific default configuration in `/etc/ssh/ssh_config`:
   ```
   # BEGIN ANSIBLE MANAGED BLOCK
   Host *
   StrictHostKeyChecking no     <------ this particular line
   HashKnownHosts no
   SendEnv LANG LC_*
   # END ANSIBLE MANAGED BLOCK
   ```
   
   libssh will consult configuration files on hard-coded default system
   locations and alter its behavior based on settings found in them.
   
   This libssh behavior is present in all supported versions:
   https://gitlab.com/libssh/libssh-mirror/-/commit/5a2abd34ce9ad97c69906c5fb7b07e26e96fceaa
   https://gitlab.com/libssh/libssh-mirror/-/tags/libssh-0.9.0
   
   It means the existing disable logic based on libssh version worked by
   coincidence, and what needs to be checked is these configurations
   to decide if it's safe to run the test. Another, simpler option is
   to also accept the result code 67, though in that case the test
   wouldn't actually test what we want, but would pass anyway.
   
   With the old `oldlibssh` workaround deleted, and the problematic setting
   manually overridden (`StrictHostKeyChecking yes`):
   - CircleCI Ubuntu 20.04 passes with 1459 enabled:
     https://app.circleci.com/pipelines/github/curl/curl/16483/workflows/87a9f389-76a2-4a32-acde-c0b411a4c842/jobs/155302
   - CircleCI Ubuntu 22.04 does too:
     https://app.circleci.com/pipelines/github/curl/curl/16483/workflows/87a9f389-76a2-4a32-acde-c0b411a4c842/jobs/155303
   
   To fix, replace the `runtests` `oldlibssh` detection logic to parse
   libssh config files (instead of checking for libssh version) and disable
   test 1459 based on that. Notice the detection is making a light attempt
   to parse these files, and does not implement most config file features
   (such as includes, quoted values and `=` operator.)
   
   The new runtests workaround tests OK with the:
   - default CircleCI configuration, disabling 1459 automatically.
   - a sudoless configuration fix, with 1459 run successfully.
     Also keep setting this option in CircleCI jobs.
   - a sudo configuration fix, with 1459 run successfully.
   Ref: https://app.circleci.com/pipelines/github/curl/curl/16492/workflows/56f39335-97ba-412c-9a9b-3d662694375a
   
   GHA jobs are not affected and they work fine, with 1459 running successfully
   before and after this patch.
   
   It's possible the libssh API offers ways to control config file use
   and/or set the strict host checking option programatically. Maybe
   to enable in debug mode (albeit CircleCI job are not debug-enabled),
   or offer an option for them. It may be something for a future patch.
   
   Follow-up to 23540923e1b09ce00dc08bab3bb3a2c0e62ba4e7 #8622
   Follow-up to 4b01a57c95fd4c041dfa4a41834c761658ea89ee #8548
   Follow-up to bdc664a64002a7df66f34159454844e6b6f5515f #8490
   Follow-up to 7c140f6b2d90975629ba81a23acbef4363a3e6fe #8444
   
   Ref: 6d9c5c91b9fd5f3a2733363d1ded8f70b6c24e5d #19549
   
   Closes #19557

   Changed files

   • .circleci/config.yml
   • docs/tests/FILEFORMAT.md
   • tests/data/test1459
   • tests/runtests.pl

2. Change #249010

   Category	curl
   Changed by	x2018 <xkernel.wangohnoyoudont@foxmail.com>
   Changed at	Sun 16 Nov 2025 23:32:41
   Repository	https://github.com/curl/curl.git
   Project	curl
   Branch	master
   Revision	205a8e861ff9a05ac81d21f9589e7d2de270ff66

   Comments

   wolfssl: fix a potential memory leak of session
   Closes #19555

   Changed files

   • lib/vtls/wolfssl.c