Builder curl-unthreaded-solaris10-i386 Build #15949

Results:

Failed runtest

SourceStamp:

BuildSlave:

Reason:

The SingleBranchScheduler scheduler named 'schedule-curl-unthreaded-solaris10-i386' triggered this build

Steps and Logfiles:

1. git update ( 14 secs )
   1. stdio
2. Runtest './tests/testcurl.pl --nogitpull ...' failed ( 2 hrs, 59 mins, 10 secs )
   1. stdio
   2. resultlog
3. Mail result 'cat resultlog ...' ( 0 secs )
   1. stdio

Build Properties:

Forced Build Properties:

Responsible Users:

1. Daniel Stenberg

   danielohnoyoudont@haxx.se
2. Viktor Szakats

   commitohnoyoudont@vsz.me

Timing:

All Changes:

:

1. Change #248447

   Category	curl
   Changed by	Daniel Stenberg <danielohnoyoudont@haxx.se>
   Changed at	Wed 12 Nov 2025 10:27:48
   Repository	https://github.com/curl/curl.git
   Project	curl
   Branch	master
   Revision	4bb6a5d50f11356bc5b83fba64a7db5aeeca3ee5

   Comments

   tool_operate: use curlx_str_number intead of atoi
   For consistency. This instance is for debug-only code and is not
   important.
   
   Closes #19480

   Changed files

   • src/tool_operate.c

2. Change #248448

   Category	curl
   Changed by	Daniel Stenberg <danielohnoyoudont@haxx.se>
   Changed at	Wed 12 Nov 2025 10:27:54
   Repository	https://github.com/curl/curl.git
   Project	curl
   Branch	master
   Revision	207721165e637de16413189f414a593d580db965

   Comments

   src/checksrc: ban atoi use

   Changed files

   • src/.checksrc

3. Change #248449

   Category	curl
   Changed by	Daniel Stenberg <danielohnoyoudont@haxx.se>
   Changed at	Wed 12 Nov 2025 10:30:59
   Repository	https://github.com/curl/curl.git
   Project	curl
   Branch	master
   Revision	97b0abb46bc03e6f59a90666df6f0dc138fa2a04

   Comments

   noproxy: replace atoi with curlx_str_number
   To better reject junk and detect overflows. There were already
   additional precautions and protections in place, but this is cleaner.
   
   Extended the 1614 unit tests with some more bad syntax cases.
   
   Closes #19475

   Changed files

   • lib/noproxy.c
   • tests/data/test1614
   • tests/unit/unit1614.c

4. Change #248453

   Category	curl
   Changed by	Daniel Stenberg <danielohnoyoudont@haxx.se>
   Changed at	Wed 12 Nov 2025 10:41:52
   Repository	https://github.com/curl/curl.git
   Project	curl
   Branch	master
   Revision	3b4bf3fcfaa08a9dad40742ce0f3fb4a6a266d5a

   Comments

   telnet: replace atoi for BINARY handling with curlx_str_number
   Also, only consider 0 to be a valid switch-off. Previously any value
   except 1 had the same effect.
   
   Closes #19477

   Changed files

   • lib/telnet.c

5. Change #248454

   Category	curl
   Changed by	Daniel Stenberg <danielohnoyoudont@haxx.se>
   Changed at	Wed 12 Nov 2025 10:44:49
   Repository	https://github.com/curl/curl.git
   Project	curl
   Branch	master
   Revision	7aaf9a3152ae70245b0cfbc6d7a2aef83fc9f20d

   Comments

   http: replace atoi use in Curl_http_follow with curlx_str_number
   In an attempt to weed out atoi() use all over.
   
   Closes #19478

   Changed files

   • lib/http.c

6. Change #248472

   Category	curl
   Changed by	Daniel Stenberg <danielohnoyoudont@haxx.se>
   Changed at	Wed 12 Nov 2025 11:18:18
   Repository	https://github.com/curl/curl.git
   Project	curl
   Branch	master
   Revision	7428060b0ebc3a6892687bed20013d0c69adc0cc

   Comments

   libssh2: cleanup ssh_force_knownhost_key_type
   - Use arrays instead pointers
   - Narrow variable scopes
   
   Closes #19479

   Changed files

   • lib/vssh/libssh2.c

7. Change #248473

   Category	curl
   Changed by	Daniel Stenberg <danielohnoyoudont@haxx.se>
   Changed at	Wed 12 Nov 2025 11:18:26
   Repository	https://github.com/curl/curl.git
   Project	curl
   Branch	master
   Revision	b2e0b4d008ee01ab8965e095822f31f9ff2da723

   Comments

   libssh2: replace atoi() in ssh_force_knownhost_key_type
   Closes #19479

   Changed files

   • lib/vssh/libssh2.c

8. Change #248474

   Category	curl
   Changed by	Viktor Szakats <commitohnoyoudont@vsz.me>
   Changed at	Wed 12 Nov 2025 11:21:25
   Repository	https://github.com/curl/curl.git
   Project	curl
   Branch	master
   Revision	9c87b3ef80910e7985e24ac30f7de4772e3afbbe

   Comments

   OS400/makefile.sh: fix shellcheck warning SC2038 differently
   Reported-by: Patrick Monnerat
   Bug: https://github.com/curl/curl/pull/19451#discussion_r2517335957
   Follow-up to af5a1647afa8aaf7cafc1e87af529a4cd48cb240 #19451
   
   Closes #19482

   Changed files

   • packages/OS400/makefile.sh

9. Change #248484

   Category	curl
   Changed by	Daniel Stenberg <danielohnoyoudont@haxx.se>
   Changed at	Wed 12 Nov 2025 12:19:12
   Repository	https://github.com/curl/curl.git
   Project	curl
   Branch	master
   Revision	a862920246b1b7b3852463eb5102dc85e070c95b

   Comments

   hostip: don't store negative lookup on OOM
   When convert_ipaddr_direct() returns error due to OOM, it must not be
   stored as a negative cache result.
   
   Closes #19484

   Changed files

   • lib/hostip.c

10. Change #248487

    Category	curl
    Changed by	Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at	Wed 12 Nov 2025 12:51:29
    Repository	https://github.com/curl/curl.git
    Project	curl
    Branch	master
    Revision	96a5ce5a82eb0f08650649ffafb7bb4e51fc4444

    Comments

    test2405: report `fd_count*` variables on failure
    This test is frequently failing in macOS !ssl jobs:
    
    "curl_multi_waitfds() should return at least the number of fds needed":
    https://github.com/curl/curl/actions/runs/19290229745/job/55159015942 AM clang !ssl !debug brotli zstd
    https://github.com/curl/curl/actions/runs/19289578332/job/55157058146 AM clang !ssl !debug brotli zstd
    https://github.com/curl/curl/actions/runs/19188515879/job/54859474947 AM clang !ssl
    https://github.com/curl/curl/actions/runs/19165077858/job/54783776869 AM clang !ssl libssh2 AppleIDN
    https://github.com/curl/curl/actions/runs/19046554157/job/54396096298 AM gcc-12 !ssl !debug
    
    "curl_multi_waitfds() should return the amount of fds needed if enough isn't passed in":
    https://github.com/curl/curl/actions/runs/19184546172/job/54848549080 AM gcc-13 !ssl !debug
    
    Also high on the test clutch list:
    2405 FAIL times: 165
    Ref: https://testclutch.curl.se/static/reports/results-count.html
    
    ```
    libtests returned 44, when expecting 0
    
    FAIL 2405: 'checking curl_multi_waitfds functionality' multi, HTTP, HTTP/2
    ```
    44 = `CURLE_OBSOLETE44` = `TEST_ERR_FAILURE`
    
    Also: fix a newline in log output.
    
    Follow-up to c78044c07e97cb720049579f4fe3cab33a7ea8d3 #15146 #15155
    
    Closes #19481

    Changed files

    • tests/libtest/lib2405.c

11. Change #248493

    Category	curl
    Changed by	Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at	Wed 12 Nov 2025 13:49:30
    Repository	https://github.com/curl/curl.git
    Project	curl
    Branch	master
    Revision	ebead15f4e3cc682bed04f9a5d0fd74670b7f177

    Comments

    lib1509: make callbacks static
    Closes #19488

    Changed files

    • tests/libtest/lib1509.c

12. Change #248494

    Category	curl
    Changed by	Viktor Szakats <commitohnoyoudont@vsz.me>
    Changed at	Wed 12 Nov 2025 13:56:02
    Repository	https://github.com/curl/curl.git
    Project	curl
    Branch	master
    Revision	2c7e1792a06b81b2bf41c9d348d374a83621340b

    Comments

    test2405: split off H2 tests to new test 2407, fix callback prototype
    To untangle the different curl/server requirements of these tests.
    Also to make this test run for non-H2 builds. Searching the cause of
    the flakiness documented in #19481.
    
    Also:
    - fix the callback function prototype. Detected by ASAN with this patch,
      though the issue was pre-existing.
      ```
      lib/cw-out.c:211:14: runtime error: call to function emptyWriteFunc
        through pointer to incorrect function type
        'unsigned long (*)(char *, unsigned long, unsigned long, void *)'
      tests/libtest/lib2405.c:72: note: emptyWriteFunc defined here
      SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior lib/cw-out.c:211:14
      ```
      Ref: https://github.com/curl/curl/actions/runs/19296686908/job/55180334364?pr=19487#step:44:3768
    
    Follow-up to 96a5ce5a82eb0f08650649ffafb7bb4e51fc4444 #19481
    
    Closes #19487

    Changed files

    • tests/data/Makefile.am
    • tests/data/test2405
    • tests/data/test2407
    • tests/libtest/lib2405.c