Builder curl-pr-unthreaded-solaris10-sparc Build #2398
Results:
Build successful
SourceStamp:
Project | curl/curl |
Repository | https://github.com/curl/curl |
Branch | master |
Revision | dac78ae638048a212f446f28f1f5731e594dce94 |
Got Revision | dac78ae638048a212f446f28f1f5731e594dce94 |
Changes | 58 changes |
BuildSlave:
unstable10sReason:
The AnyBranchScheduler scheduler named 'schedule-curl-pr' triggered this build
Steps and Logfiles:
Build Properties:
Name | Value | Source |
---|---|---|
branch | master | Build |
builddir | /export/home/buildbot-unstable10s/slave/curl-pr-unthreaded-solaris10-sparc | slave |
buildername | curl-pr-unthreaded-solaris10-sparc | Builder |
buildnumber | 2398 | Build |
codebase | Build | |
got_revision | dac78ae638048a212f446f28f1f5731e594dce94 | Git |
osplatform | SPARC | SetPropertyFromCommand Step |
osrelease | 10 | SetPropertyFromCommand Step |
project | curl/curl | Build |
repository | https://github.com/curl/curl | Build |
revision | dac78ae638048a212f446f28f1f5731e594dce94 | Build |
scheduler | schedule-curl-pr | Scheduler |
slavename | unstable10s | BuildSlave |
workdir | /export/home/buildbot-unstable10s/slave/curl-pr-unthreaded-solaris10-sparc | slave (deprecated) |
Forced Build Properties:
Name | Label | Value |
---|
Responsible Users:
- Andrewakirillo@uk.ibm.com
- Dan Fandrichdan@coneharvesters.com
- Daniel Stenbergdaniel@haxx.se
- Jay Satiroraysatiro@yahoo.com
- Nigel Brittainnbaws@amazon.com
- Stefan Eissingstefan@eissing.org
- Viktor Szakatscommit@vsz.me
- Yedaya Katsmanyedaya.ka@gmail.com
- renovate[bot]29139614+renovate[bot]@users.noreply.github.com
Timing:
Start | Sat Apr 5 01:40:13 2025 |
End | Sat Apr 5 12:16:14 2025 |
Elapsed | 10 hrs, 36 mins, 1 secs |
All Changes:
:
Change #226213
Category None Changed by Viktor Szakats <commit @vsz.me>Changed at Mon 31 Mar 2025 22:49:18 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 1dd361cde8b2b89617ac612506c04fab9e8a0338 Comments
libssh2: show crypto backend in the verbose connect log With libssh2 1.11.0 or newer. Different crypto backends may offer different features, e.g. in the keys and algos they support. Examples: ``` * Trying 127.0.0.1:22... * Connected to localhost (127.0.0.1) port 22 * libssh2 crypto backend: openssl compatible [or] * libssh2 crypto backend: WinCNG ``` Also fix indentation and drop redundant curly braces. Closes #16790
Changed files
- lib/vssh/libssh2.c
Change #226263
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Tue 01 Apr 2025 11:29:14 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 66c95f05fae6734144fcd9cee8937457b67c71ed Comments
tests/certs/Makefile.am: avoid superfluous cert re-generation Fixes #16897 Closes #16899
Changed files
- tests/Makefile.am
- tests/certs/Makefile.am
Change #226264
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Tue 01 Apr 2025 11:30:05 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 0d85c8c49d90fa8c1475832e0a8f1916a04d9a69 Comments
tool_paramhlp: make proto2num skip leading commas better Closes #16892
Changed files
- src/tool_paramhlp.c
Change #226265
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Tue 01 Apr 2025 11:31:48 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 0042f11d6e45261a05492a89de9338767b861ed6 Comments
GHA: run random curl command lines for N seconds in CI In the memory and address sanitizer builds. Verify that nothing unexpected happens. Starting out with 60 second runs. The script does not set any seed so it runs with a new random every time, meaning that if it fails in a single CI run it might not fail in a subsequent one: but it should still show the full command that failed to enable us to reproduce it locally. We can work on improving the seed situation later if this script turns useful. Closes #16884
Changed files
- .github/scripts/randcurl.pl
- .github/workflows/linux.yml
Change #226270
Category None Changed by Viktor Szakats <commit @vsz.me>Changed at Tue 01 Apr 2025 11:46:17 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 93964c21f403bdb157c5a0cbb3e9670e36f7a386 Comments
runtests: fix bundled test invocation with `-g` option Fixes: ``` $ ./runtests.pl -g 1940 ./libtest/libtests lib1940: No such file or directory. Argument list to give program being debugged when it is started is "http://127.0.0.1:44547/1940". ``` Reported-by: Daniel Stenberg Fixes #16893 Closes #16898
Changed files
- tests/runner.pm
Change #226279
Category None Changed by Viktor Szakats <commit @vsz.me>Changed at Tue 01 Apr 2025 12:48:04 Repository https://github.com/curl/curl Project curl/curl Branch master Revision fddc7a67eaf2ade627fef78e8fde2d590b9021cf Comments
tests/README: document test bundles Closes #16902
Changed files
- .github/scripts/spellcheck.words
- tests/README.md
Change #226280
Category None Changed by Viktor Szakats <commit @vsz.me>Changed at Tue 01 Apr 2025 12:48:04 Repository https://github.com/curl/curl Project curl/curl Branch master Revision fe9c99e377f20555d928e676adad817ec5d2576c Comments
GHA/windows: drop GnuTLS-fork from vcpkg MultiSSL job curl now has a working GnuTLS CI job, with tests, with MSYS2. The MultiSSL build scenario is now tested on macOS. The vcpkg GnuTLS package seems to have a deep dependency tree with large packages that need to be rebuilt relatively frequently. Since they can't fit into to the time limit, these cause CI failures. To stabilize CI, drop the `shiftmedia-libgnutls` dependency. Partial revert of e86f99824c4de0024cc90bca53efe205fd1c1dcc #16623 Ref: https://github.com/curl/curl/actions/runs/14192680124/job/39760753274?pr=16902 Closes #16904
Changed files
- .github/workflows/windows.yml
Change #226289
Category None Changed by Stefan Eissing <stefan @eissing.org>Changed at Tue 01 Apr 2025 14:19:27 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 1f844dd3f0e66f19377b5158201f5b6eec61507f Comments
http2: fix stream assignemnt for pushes When a PUSH_PROMISE was received, the h2_stream object was assigned to the wrong `newhandle->mid` and was thereafter not found. This led to internal confusion, because the nghttp2 stream user_data was not cleared and an invalid easy handle was use for trace messages, resulting in a crash. Reported-by: Viktor Szakats Fixes #16881 Closes #16905
Changed files
- lib/http2.c
Change #226292
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Tue 01 Apr 2025 14:28:18 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 50c1e62fa417805ddce9aec27ba585995a357ee9 Comments
multi_ev: remove redundant check from mev_get_last_pollset Pointed out by CodeSonar Closes #16894
Changed files
- lib/multi_ev.c
Change #226293
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Tue 01 Apr 2025 14:29:04 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 49a87e93c3476ffb168f2ebe6918c31ef023fd9e Comments
tool_getparam: avoid redundant condition in set_rate When the number parsing fails, the pointer is never moved so there's no point in checking that. Pointed out by CodeSonar Closes #16895
Changed files
- src/tool_getparam.c
Change #226296
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Tue 01 Apr 2025 15:27:56 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 63c1e6482a7fb195db155e1e769903e020e70874 Comments
vtls_scache: remove "Unreachable Call" The condition required to reach this call could not happen, because cf_ssl_scache_get() already checks the same condition and returns NULL for 'scache' prior to this. Found by CodeSonar Closes #16896
Changed files
- lib/vtls/vtls_scache.c
Change #226335
Category None Changed by Viktor Szakats <commit @vsz.me>Changed at Wed 02 Apr 2025 01:14:29 Repository https://github.com/curl/curl Project curl/curl Branch master Revision c6a324d5b9075b7988e6d2a3c6c320dfa8a152a3 Comments
GHA/windows: make libssh2 install a per job config To allow making per-job variations for SSH backends. Also: - fix Cygwin builds to not ignore per-job `install:` items. It worked by accident before this patch. Follow-up to 66313cc036671cd4d3e72db65a79a715c7b8f154 #16629 Closes #16911
Changed files
- .github/workflows/windows.yml
Change #226343
Category None Changed by Viktor Szakats <commit @vsz.me>Changed at Wed 02 Apr 2025 01:38:12 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 5ad32b05d5fb5b489528b91554cf35c3ba8753e9 Comments
GHA/windows: move libssh job from vcpkg to MSYS2 To avoid upstream issue where libssh no longer builds with vcpkg: ``` error: building libssh:x64-windows failed with: BUILD_FAILED ``` Ref: https://github.com/curl/curl/actions/runs/14206672441/job/39805869213?pr=16909#step:5:64 Bug: https://github.com/curl/curl/pull/16909#issuecomment-2770792320 Closes #16910
Changed files
- .github/workflows/windows.yml
Change #226348
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Wed 02 Apr 2025 07:46:30 Repository https://github.com/curl/curl Project curl/curl Branch master Revision b0c5a1abdbf598721435a4cc93b299c3dc59f56d Comments
THANKS: new contributors from 8.13.0 release
Changed files
- docs/THANKS
Change #226349
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Wed 02 Apr 2025 07:46:30 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 1c3149881769e7bd79b072e48374e4c2b3678b2f Comments
RELEASE-NOTES: synced
Changed files
- RELEASE-NOTES
Change #226362
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Wed 02 Apr 2025 11:44:26 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 8c2392e564d108480e395811d421558e38e99188 Comments
contrithanks.sh: drop set -e Makes the script work again Closes #16914
Changed files
- scripts/contrithanks.sh
Change #226370
Category None Changed by Viktor Szakats <commit @vsz.me>Changed at Wed 02 Apr 2025 12:54:46 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 202a333e4d0a7e2c256f36df85f94731d25117f1 Comments
processhelp.pm: avoid potential endless loop, log more (Windows) `pidwait()` is a function to wait for a PID to disappear from the list of processes. On Windows change this function to: - reduce the frequency of calling the external command `tasklist` to query the list of processes, including Windows-native ones, to 0.2s (from 0.01s). - print a message when the wait exceeds 5 second marks. - give up after 20 seconds of total wait, and print a message. Also log `taskkill` commands to stdout instead of the log. To potentially avoid hangs seen in CI, and make these spots more transparent through the log. Ref: #16840 Ref: #14854 Closes #16908
Changed files
- tests/processhelp.pm
Change #226378
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Wed 02 Apr 2025 14:01:27 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 1d84d683bb44c305c13188b31d2117ff95a22da7 Comments
test: make unittest 1308 into a libtest Test 1308 was wrongly marked a unit test when in reality it is a libtest. Closes #16891
Changed files
- tests/data/test1308
- tests/libtest/CMakeLists.txt
- tests/libtest/Makefile.am
- tests/libtest/Makefile.inc
- tests/libtest/lib1301.c
- tests/libtest/lib1308.c
- tests/unit/Makefile.inc
- tests/unit/unit1308.c
Change #226387
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Wed 02 Apr 2025 14:17:56 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 0c6e63a1be26a5ba4c953bcacd29c1db412e7e95 Comments
lib: unify conversions to/from hex Curl_hexbyte - output a byte as a two-digit ASCII hex number Curl_hexval - convert an ASCII hex digit to its binary value ... instead of duplicating similar code and hexdigit strings in numerous places. Closes #16888
Changed files
- lib/escape.c
- lib/escape.h
- lib/http_aws_sigv4.c
- lib/inet_pton.c
- lib/strparse.c
- lib/strparse.h
- lib/urlapi.c
- lib/vtls/keylog.c
Change #226388
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Wed 02 Apr 2025 14:17:56 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 8a45c2851aeb6f3ec18ad5c39c4042ab516891dd Comments
lib1960: revert the use of libcurl's inet_pton Since it now uses hex conversion code from strparse as well. Closes #16888
Changed files
- tests/libtest/Makefile.inc
- tests/libtest/lib1960.c
Change #226422
Category None Changed by Yedaya Katsman <yedaya.ka @gmail.com>Changed at Wed 02 Apr 2025 22:46:53 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 878d1fc3406c5bce5ac48af320f43e3cee6456a4 Comments
tests/serverhelp: remove last remnants of http-pipe server Followup on https://github.com/curl/curl/pull/5921 Closes #16924
Changed files
- tests/serverhelp.pm
Change #226423
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Wed 02 Apr 2025 22:51:06 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 673c56a034b238de59b22e354efa6d5c6d68670a Comments
RELEASE-NOTES: synced and bump to 8.13.1 for now
Changed files
- RELEASE-NOTES
- include/curl/curlver.h
Change #226440
Category None Changed by Jay Satiro <raysatiro @yahoo.com>Changed at Wed 02 Apr 2025 23:45:57 Repository https://github.com/curl/curl Project curl/curl Branch master Revision e0b4ea889f5e5caffe9dc3cb750e9d1ba85973b4 Comments
INSTALL-CMAKE.md: fix typo
Changed files
- docs/INSTALL-CMAKE.md
Change #226442
Category None Changed by Viktor Szakats <commit @vsz.me>Changed at Thu 03 Apr 2025 00:19:06 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 22352e627da60fc1b3965f4aa95ef5219a9df845 Comments
configure: restore link checks The omitted link checks were not what I though they were. Omitting one caused a mis-detection on Solaris, where the compile check alone mis-detects `CloseSocket` as present. Restore link checks for these functions: `closesocket`, `ioctlsocket`, `socket`, `freeaddrinfo`, `getaddrinfo`, `gethostname`, `getpeername`, `getsockname`, `CloseSocket` (AmigaOS), `IoctlSocket` (AmigaOS). Also re-sync link check code snippets with the ones in current master. Partial revert of, regression from bd9f9b085aa242a5e93be0b2da96ce498d7813c4 #16377 Reported-by: Dagobert Michelsen Bug: https://curl.se/mail/lib-2025-04/0004.html Fixes #16915 Closes #16917
Changed files
- m4/curl-functions.m4
Change #226449
Category None Changed by Viktor Szakats <commit @vsz.me>Changed at Thu 03 Apr 2025 01:12:19 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 87168807b215b83141220b34ebb30a3e51e61770 Comments
eventfd: fix feature guards Enable eventfd code consistently when both `HAVE_EVENTFD` and `HAVE_SYS_EVENTFD_H` macros are defined. Before this patch `HAVE_EVENTFD` guarded it alone, though the code also required the header, which was guarded by `HAVE_SYS_EVENTFD_H`. These should normally be detected in pairs. When they aren't, omit using `eventfd()` to avoid calling it without a known matching header. If this disables valid cases (e.g. some system declares this function via a different header), feature detection and the code may be extended for those cases. If these are known to come in pairs, always, another option is detect them both at build stage, and forward a single macro to C. Reported-by: Abhinav Singhal Bug: https://curl.se/mail/lib-2025-04/0000.html Closes #16909
Changed files
- lib/asyn-thread.c
- lib/curl_setup.h
- lib/multi.c
- lib/socketpair.c
- lib/socketpair.h
Change #226471
Category None Changed by Andrew <akirillo @uk.ibm.com>Changed at Thu 03 Apr 2025 08:25:09 Repository https://github.com/curl/curl Project curl/curl Branch master Revision fe5f435b42a6c928b57c61db5d57f96b5c5a39be Comments
http_negotiate: fix non-SSL build with GSSAPI Fixes #16919 Closes #16921
Changed files
- lib/http_negotiate.c
Change #226472
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Thu 03 Apr 2025 08:26:33 Repository https://github.com/curl/curl Project curl/curl Branch master Revision daa86936190af30ed58932ddd24db97f708337a9 Comments
VERSIONS: list all past releases This document now lists all previous releases. This allows us to verify that documentation refers to actual release versions. Test 971 now verifies options-in-versions and all command line options documentation individually. Fixed a few discrepancies. Test 1488 verifies libcurl options "Added-in" to exist. Fixed a few discrepancies there as well. Closes #16907
Changed files
- docs/VERSIONS.md
- docs/cmdline-opts/ftp-skip-pasv-ip.md
- docs/cmdline-opts/proto-redir.md
- docs/cmdline-opts/proto.md
- docs/libcurl/curl_global_trace.md
- docs/libcurl/curl_version_info.md
- docs/libcurl/symbols-in-versions
- docs/options-in-versions
- tests/Makefile.am
- tests/allversions.pm
- tests/data/test1488
- tests/data/test971
- tests/test1488.pl
- tests/test971.pl
Change #226484
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Thu 03 Apr 2025 10:52:47 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 5caba3bd97a14b64d906ece77bc0e2b339161a1f Comments
curl_krb5: only use functions if FTP is still enabled Reported-by: x1sc0 on github Fixes #16925 Closes #16931
Changed files
- lib/curl_krb5.h
Change #226487
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Thu 03 Apr 2025 11:10:47 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 6e00db58fbeaa09e58c20a606e00b83743e81c7f Comments
configure: fix --disable-rt This option now better only prevents the actual -lrt to be used, and thus has no effect if the system does not need -lt for the monotonic clock etc. Fixes #16932 Closes #16934
Changed files
- acinclude.m4
- configure.ac
Change #226489
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Thu 03 Apr 2025 11:25:25 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 4cf9e87fca2ce14712e6d05bccc8c9e70575e70d Comments
if2ip: build the function also if FTP is present Previously it was not compiled if CURL_DISABLE_BINDLOCAL is set, but the FTP code is also using this function. Easily found by using configure --disable-bindlocal without disabling FTP. Closes #16933
Changed files
- lib/if2ip.c
Change #226493
Category None Changed by Stefan Eissing <stefan @eissing.org>Changed at Thu 03 Apr 2025 11:37:45 Repository https://github.com/curl/curl Project curl/curl Branch master Revision b56b0c078e285aeea89ab01b913a502fb42bbdfd Comments
vtls: fix build with ssl but without http Fixes #16935 Closes #16937
Changed files
- lib/vtls/vtls.c
Change #226495
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Thu 03 Apr 2025 11:52:37 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 8f496d05b681f112225c839c8907b83aeebbf89b Comments
hostip: fix build without threaded-resolver and without DoH Closes #16938
Changed files
- lib/hostip.c
Change #226499
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Thu 03 Apr 2025 12:38:36 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 49701094fcc8fc510af97e439ad46415342d367f Comments
http: fix a build error when all auths are disabled error: ‘result’ undeclared (first use in this function) Found with randdisable Closes #16939
Changed files
- lib/http.c
Change #226503
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Thu 03 Apr 2025 13:37:17 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 78710ee955efb91e2d111d68c7ad7d9707848621 Comments
conncache: make Curl_cpool_init return void Since it cannot fail, removing the return code simplifies the code paths calling this function. Closes #16936
Changed files
- lib/conncache.c
- lib/conncache.h
- lib/multi.c
- lib/share.c
Change #226506
Category None Changed by Viktor Szakats <commit @vsz.me>Changed at Thu 03 Apr 2025 14:17:37 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 3d4e4a18740585c01c1314fbca849e47229461e6 Comments
genserv.pl: fail with a message if `openssl` is missing or failing Reported-by: Tomas Volf Fixes #16926 Follow-up to 44341e736a3e2f7a2b25a774be3a9796e81abab9 #16824 Ref: #16928 Co-authored-by: Daniel Stenberg Closes #16929
Changed files
- tests/certs/genserv.pl
Change #226523
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Thu 03 Apr 2025 16:00:17 Repository https://github.com/curl/curl Project curl/curl Branch master Revision d6a626d5d8f9ab38b09cd42402e06770eb48fdbd Comments
parsedate: provide Curl_wkday also for GnuTLS builds Otherwise --disable-dateparse + --with-gnutls builds might fail. Found with randdisable Closes #16943
Changed files
- lib/parsedate.c
Change #226527
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Thu 03 Apr 2025 16:25:29 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 6140a574dec4771fe36da43d45eea2535fe6e555 Comments
tests/README.md: list the openssl tool among the prerequisites Used for test cert generation since 8.13.0 Closes #16942
Changed files
- tests/README.md
Change #226535
Category None Changed by Stefan Eissing <stefan @eissing.org>Changed at Thu 03 Apr 2025 16:40:56 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 01e76702aca1ef893d0e653a70b3261ae61899d3 Comments
dnscache: slight refactoring Slight refactoring around dnscache, e.g. hostcache - eliminate `data->state.hostcache`. Always look up relevant dnscache at share/multi. - unify naming to "dnscache", replacing "hostcache" - use `struct Curl_dnscache`, even though it just contains a `Curl_hash` for now. - add `Curl_dnscache_destroy()` for cleanup in share/multi. Closes #16941
Changed files
- lib/cshutdn.c
- lib/doh.c
- lib/hostasyn.c
- lib/hostip.c
- lib/hostip.h
- lib/multi.c
- lib/multihandle.h
- lib/setopt.c
- lib/share.c
- lib/share.h
- lib/urldata.h
- tests/unit/unit1305.c
- tests/unit/unit1607.c
- tests/unit/unit1609.c
Change #226539
Category None Changed by Stefan Eissing <stefan @eissing.org>Changed at Thu 03 Apr 2025 16:43:37 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 9b6148e9d95db54a752b03b571296c40d66e97fe Comments
async-threaded resolver: use ref counter Allocate the data shared between a transfer and an aync resolver thread separately and use a reference counter to determine its release. Change `Curl_thread_destroy()` to clear the thread handle, so that the thread is considered "gone" and we do not try to join (and fail to) afterwards. Retake of the revert in fb15a986c0d947ae6b9dd6 Closes #16916
Changed files
- lib/asyn-ares.c
- lib/asyn-thread.c
- lib/asyn.h
- lib/curl_threads.c
- lib/curl_threads.h
- lib/multi.c
- lib/socks.c
- tests/libtest/lib3207.c
Change #226544
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Thu 03 Apr 2025 17:19:59 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 8f65bd69774caf957780c67e13d2f3c502d69799 Comments
asyn-thread: fix build without socketpair Follow-up to 9b6148e9d95db54a752b03b571296c40d66e97fe Closes #16945
Changed files
- lib/asyn-thread.c
Change #226547
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Thu 03 Apr 2025 17:23:58 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 681df5ec517e1477b07b5df2df42bc0617f33c18 Comments
tests/README.md: document --test-duphandle Follow-up to cbafcec50bc99ba0dd0490e6 Closes #16944
Changed files
- tests/README.md
Change #226549
Category None Changed by renovate[bot] <29139614+renovate[bot] @users.noreply.github.com>Changed at Thu 03 Apr 2025 17:44:34 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 69d58309afa7a6ea3cec898f4b569b89ba945ff5 Comments
GHA: update cloudflare/quiche to v0.23.5 Closes #16913
Changed files
- .github/workflows/http3-linux.yml
Change #226554
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Thu 03 Apr 2025 19:55:01 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 7e0eea7d7b34b81ca02ffb995ebea22c02cb92d2 Comments
tests: mark ipfs tests to require ipfs Fixes #16947 Reported-by: Daniel Engberg Closes #16948
Changed files
- tests/data/test722
- tests/data/test723
- tests/data/test724
- tests/data/test725
- tests/data/test726
- tests/data/test727
- tests/data/test730
- tests/data/test731
- tests/data/test732
- tests/data/test733
- tests/data/test734
- tests/data/test735
- tests/data/test736
- tests/data/test737
- tests/data/test738
- tests/data/test739
- tests/data/test740
- tests/data/test741
Change #226556
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Thu 03 Apr 2025 20:37:17 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 982d0a14b637f6591bfb52e44448fa70263665a5 Comments
RELEASE-NOTES: synced
Changed files
- RELEASE-NOTES
Change #226572
Category None Changed by Viktor Szakats <commit @vsz.me>Changed at Thu 03 Apr 2025 23:18:55 Repository https://github.com/curl/curl Project curl/curl Branch master Revision c6bd2e6a9a7652c6e8d2807f346973d3f1c5a808 Comments
tests: prefer `--insecure` over `-k` To make it uniform in all tests, and greppability. Also: - replace `-k` flag with `-q` in test 1268. (the actual flag doesn't matter in this test) - keep `-k` in test 300 to test its short form. (also verified to fail without a working `-k`) Closes #16878
Changed files
- tests/data/test1112
- tests/data/test1268
- tests/data/test1272
- tests/data/test1470
- tests/data/test1561
- tests/data/test1562
- tests/data/test2400
- tests/data/test2401
- tests/data/test2403
- tests/data/test2406
- tests/data/test2501
- tests/data/test300
- tests/data/test301
- tests/data/test302
- tests/data/test303
- tests/data/test304
- tests/data/test306
- tests/data/test307
- tests/data/test308
- tests/data/test309
- tests/data/test325
- tests/data/test364
- tests/data/test400
- tests/data/test401
- tests/data/test402
- tests/data/test403
- tests/data/test405
- tests/data/test406
- tests/data/test407
- tests/data/test408
- tests/data/test409
- tests/data/test410
- tests/data/test414
- tests/data/test445
- tests/data/test474
- tests/data/test628
- tests/data/test780
- tests/data/test781
- tests/data/test782
- tests/data/test783
- tests/data/test987
- tests/data/test988
- tests/data/test989
Change #226574
Category None Changed by Viktor Szakats <commit @vsz.me>Changed at Thu 03 Apr 2025 23:23:37 Repository https://github.com/curl/curl Project curl/curl Branch master Revision bdc42ba23e0ec6fdda74ed93b34373235fa62cd6 Comments
GHA/curl-for-win: switch to `podman` (from `docker`) Closes #16727
Changed files
- .github/workflows/curl-for-win.yml
Change #226575
Category None Changed by Yedaya Katsman <yedaya.ka @gmail.com>Changed at Thu 03 Apr 2025 23:30:36 Repository https://github.com/curl/curl Project curl/curl Branch master Revision fe1ba25c87e3fe1f797051ac4df96df7549e4d3a Comments
rustls: make max size of cert and key reasonable SIZE_MAX is an very overkill size for certificates or keys, lower it to 100KiB for both certificate and keys. The default max size of openssl is 100KiB for the entire chain [1], and it seems firefox fails at ~60kb [2]. Found by https://github.com/curl/curl/pull/16923 [0] https://docs.openssl.org/3.2/man3/SSL_CTX_set_max_cert_list/#notes [2] https://0x00.cl/blog/2024/exploring-tls-certs/ Closes #16951
Changed files
- lib/dynbuf.h
- lib/vtls/rustls.c
Change #226581
Category None Changed by Dan Fandrich <dan @coneharvesters.com>Changed at Fri 04 Apr 2025 01:14:34 Repository https://github.com/curl/curl Project curl/curl Branch master Revision eb0c622a5b5bc6221f96e62ecee8aef66eb9edd7 Comments
scripts: fix --opts-dir help in completion.pl The help text gave the wrong option name. Reported-by: Daniel Engberg Ref: #16946
Changed files
- scripts/completion.pl
Change #226585
Category None Changed by Viktor Szakats <commit @vsz.me>Changed at Fri 04 Apr 2025 02:34:52 Repository https://github.com/curl/curl Project curl/curl Branch master Revision b809629f8c04f5cc8bcaf26cbf8e961fd9f2487d Comments
cmake: use absolute paths for completion targets Fixing potential: ``` CMake Error at scripts/CMakeLists.txt:72 (install): install FILES given directory "/usr/ports/ftp/curl/work/.build/scripts/" to install. ``` Reported-by: Daniel Engberg Fixes #16946 Follow-up to c8b0f0c9ad78eafc6c8f0005113de346ee797c21 #16833 Closes #16954
Changed files
- scripts/CMakeLists.txt
Change #226591
Category None Changed by Nigel Brittain <nbaws @amazon.com>Changed at Fri 04 Apr 2025 08:54:09 Repository https://github.com/curl/curl Project curl/curl Branch master Revision c871dcb612f63d51be014ff6fc2ba5a8d3300efb Comments
http_aws_sigv4: add additional verbose log statements To use curl as a tool for troubleshooting SigV4 signing, it is useful to have the 'Canonical Request', 'String To Sign' and 'Signature' calculations output. Closes #16952
Changed files
- lib/http_aws_sigv4.c
Change #226593
Category None Changed by Jay Satiro <raysatiro @yahoo.com>Changed at Fri 04 Apr 2025 09:40:47 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 997e55d5a7d6a20eead3fdf067be1897828826ba Comments
tests: use a more portable null device path - Use File::Spec->devnull() to get the null device path. Prior to this change we used NUL for Windows native perl and /dev/null otherwise. Bug: https://github.com/curl/curl/pull/16929#discussion_r2025718160 Reported-by: Viktor Szakats Closes https://github.com/curl/curl/pull/16930
Changed files
- tests/certs/genserv.pl
- tests/globalconfig.pm
- tests/http2-server.pl
- tests/http3-server.pl
Change #226608
Category None Changed by Daniel Stenberg <daniel @haxx.se>Changed at Fri 04 Apr 2025 14:23:01 Repository https://github.com/curl/curl Project curl/curl Branch master Revision db3e7a24b5339860fb91cf0d932e8ae13a01e472 Comments
hostip: show the correct name on proxy resolve error Regression, probably from 8ded8e5f3f4b6586399 (#16451) Fixes #16958 Reported-by: Jean-Christophe Amiel Closes #16961
Changed files
- lib/hostip.c
Change #226627
Category None Changed by Dan Fandrich <dan @coneharvesters.com>Changed at Fri 04 Apr 2025 17:42:43 Repository https://github.com/curl/curl Project curl/curl Branch master Revision b117d2cacfa604f591560f4504cc15c60dfa3780 Comments
tests: move a boolean variable out of the path section
Changed files
- tests/globalconfig.pm
Change #226628
Category None Changed by Dan Fandrich <dan @coneharvesters.com>Changed at Fri 04 Apr 2025 18:17:08 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 0e9f2c41b6d3c45d79aebf43cee91b046bcb4aee Comments
tests: fix some test tag mismatches
Changed files
- tests/data/test1571
- tests/data/test1572
- tests/data/test1573
- tests/data/test1574
- tests/data/test1575
- tests/data/test1576
- tests/data/test1577
- tests/data/test1578
- tests/data/test1579
- tests/data/test1580
- tests/data/test1581
Change #226640
Category None Changed by Stefan Eissing <stefan @eissing.org>Changed at Fri 04 Apr 2025 21:31:02 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 4f3c22d77d752fea6ff9ab2706f70d58882ea466 Comments
https-connect, fix httpsrr target check The HTTPSRR check on the record's target was not working as it used the wrong index on the NUL byte if the target was not NULL. Fixes #16966 Reported-by: Pavel Kropachev Closes #16968
Changed files
- lib/cf-https-connect.c
Change #226644
Category None Changed by Yedaya Katsman <yedaya.ka @gmail.com>Changed at Fri 04 Apr 2025 21:32:07 Repository https://github.com/curl/curl Project curl/curl Branch master Revision 80f9f6e59b1d642922d4f9de57b36a741bf60cd7 Comments
rand: update comment on Curl_rand_bytes weak random From what I understand both rustls and mbedTLS expose a strong random function, so as long as you have a TLS library random will be strong. Followup 89728451234a "vtls/rustls: support strong CSRNG data" Followup a90a5bccd47b "mbedtls: implement CTR-DRBG and HAVEGE random generators" Closes #16965
Changed files
- lib/rand.c
Change #226648
Category None Changed by Dan Fandrich <dan @coneharvesters.com>Changed at Fri 04 Apr 2025 22:23:15 Repository https://github.com/curl/curl Project curl/curl Branch master Revision cbb80f215e6117319958310143b73d991e15f435 Comments
tests: unify test case keywords Unify the case, punctuation and name of test case keywords so they can be more easily selected or skipped when desired. Add a few keywords that were missing. Fix a couple of typos in test names.
Changed files
- tests/data/test1101
- tests/data/test1194
- tests/data/test1252
- tests/data/test1253
- tests/data/test1255
- tests/data/test1256
- tests/data/test1257
- tests/data/test1265
- tests/data/test1289
- tests/data/test1322
- tests/data/test1550
- tests/data/test1560
- tests/data/test1630
- tests/data/test1631
- tests/data/test1632
- tests/data/test1650
- tests/data/test1654
- tests/data/test1655
- tests/data/test1709
- tests/data/test1919
- tests/data/test219
- tests/data/test23
- tests/data/test235
- tests/data/test247
- tests/data/test248
- tests/data/test260
- tests/data/test3021
- tests/data/test3022
- tests/data/test3104
- tests/data/test333
- tests/data/test357
- tests/data/test365
- tests/data/test367
- tests/data/test373
- tests/data/test417
- tests/data/test419
- tests/data/test426
- tests/data/test469
- tests/data/test470
- tests/data/test480
- tests/data/test484
- tests/data/test485
- tests/data/test505
- tests/data/test541
- tests/data/test63
- tests/data/test647
- tests/data/test693
- tests/data/test709
- tests/data/test783
- tests/data/test898
- tests/data/test899
- tests/data/test954
- tests/data/test979
- tests/data/test987
- tests/data/test992
Change #226649
Category None Changed by Dan Fandrich <dan @coneharvesters.com>Changed at Fri 04 Apr 2025 22:23:31 Repository https://github.com/curl/curl Project curl/curl Branch master Revision dac78ae638048a212f446f28f1f5731e594dce94 Comments
tests: remove some unused test case sections
Changed files
- tests/data/test1016
- tests/data/test1017
- tests/data/test1018
- tests/data/test1019
- tests/data/test1020
- tests/data/test1063
- tests/data/test1281
- tests/data/test1291
- tests/data/test1474
- tests/data/test19
- tests/data/test20
- tests/data/test2205
- tests/data/test247