Builder curl-pr-unthreaded-solaris10-i386 Build #3633

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

The AnyBranchScheduler scheduler named 'schedule-curl-pr' triggered this build

Steps and Logfiles:

1. git update ( 23 secs )
   1. stdio
2. Runtest './tests/testcurl.pl --nogitpull ...' ( 1 hrs, 15 mins, 46 secs )
   1. stdio
   2. resultlog

Build Properties:

Forced Build Properties:

Responsible Users:

1. Daniel Stenberg

   danielohnoyoudont@haxx.se

Timing:

All Changes:

:

1. Change #224774

   Category	None
   Changed by	Daniel Stenberg <danielohnoyoudont@haxx.se>
   Changed at	Wed 12 Mar 2025 11:22:49
   Repository	https://github.com/curl/curl
   Project	curl/curl
   Branch	bagder/protocol-done-needs-do
   Revision	c75c5cabe653df259a72b492ad86ce16756904e2

   Comments

   multi: call protocol handler done() only if DO or later
   
   The protocol handlers' done() function would previous get called
   unconditionally in multi_done(), no matter how far the easy handle's
   state machine has transitioned.
   
   This caused problems in IMAP which in imap_connect() initializes things
   that the imap_done() function assumes has occured. I think that seems
   like a correct assumption and we should rather make sure that the done()
   function is only called if we have reached the DO state.
   
   This problem was found using OSS-Fuzz.
   
   Assisted-by: Catena cyber

   Changed files

   • lib/multi.c

2. Change #224784

   Category	None
   Changed by	Daniel Stenberg <danielohnoyoudont@haxx.se>
   Changed at	Wed 12 Mar 2025 11:50:15
   Repository	https://github.com/curl/curl
   Project	curl/curl
   Branch	bagder/protocol-done-needs-do
   Revision	4724314c0bc19fb1b7424ffc4d86b65dbf180194

   Comments

   fixup actually from PROTOCONNECT or later

   Changed files

   • lib/multi.c

3. Change #224815

   Category	None
   Changed by	Daniel Stenberg <danielohnoyoudont@haxx.se>
   Changed at	Wed 12 Mar 2025 15:03:34
   Repository	https://github.com/curl/curl
   Project	curl/curl
   Branch	bagder/protocol-done-needs-do
   Revision	291e40ee9367f243e34d2c700642ebedb05897a8

   Comments

   multi: call protocol handler done() if PROTOCONNECT or later
   
   The protocol handlers' done() function would previous get called
   unconditionally in multi_done(), no matter how far the easy handle's
   state machine has transitioned.
   
   This caused problems in IMAP which in imap_connect() initializes things
   that the imap_done() function assumes has occured. I think that seems
   like a correct assumption and we should rather make sure that the done()
   function is only called if we have reached the PROTOCONNECT state.
   
   This problem was found using OSS-Fuzz.
   
   Assisted-by: Catena cyber
   
   Closes #16681

   Changed files

   • lib/multi.c