Builder curl-ares-solaris11-sparc Build #5342

Results:

Build successful

SourceStamp:

BuildSlave:

Reason:

The SingleBranchScheduler scheduler named 'schedule-curl-ares-solaris11-sparc' triggered this build

Steps and Logfiles:

1. git update ( 4 secs )
   1. stdio
2. Runtest './tests/testcurl.pl --nogitpull ...' ( 24 mins, 55 secs )
   1. stdio
   2. resultlog
3. Mail result 'cat resultlog ...' ( 0 secs )
   1. stdio

Build Properties:

Forced Build Properties:

Responsible Users:

1. Viktor Szakats

   commitohnoyoudont@vsz.me

Timing:

All Changes:

:

1. Change #258709

   Category	curl
   Changed by	Viktor Szakats <commitohnoyoudont@vsz.me>
   Changed at	Mon 23 Feb 2026 16:00:42
   Repository	https://github.com/curl/curl.git
   Project	curl
   Branch	master
   Revision	3058ed3df873c21ebba2007c3b12ed9f37558bfe

   Comments

   lib: use lib source directory as base include path
   Backtrack on previous change that aimed to solve the wrong `share.h`
   being included. It turns out it did not fix this issue. At the same time
   it introduced relative header filenames and the need to include the same
   headers differently depending on the source files' location, reducing
   readability and editability.
   
   Replace this method by re-adding curl's lib source directory to the
   header path and addressing headers by the their full, relative name to
   that base directory. Aligning with this method already used in src and
   tests.
   
   With these advantages:
   - makes includes easier to read, recognize, grep, sort, write, and copy
     between sources,
   - syncs the way these headers are included across curl components,
   - avoids the ambiguity between system `schannel.h`, `rustls.h` vs.
     local headers using the same names in `lib/vtls`,
   - silences clang-tidy `readability-duplicate-include` checker, which
     detects the above issue,
     Ref: https://clang.llvm.org/extra/clang-tidy/checks/readability/duplicate-include.html
   - possibly silences TIOBE coding standard warnings:
     `6.10.2.a: Don't use relative paths in #include statements.`
   - long shot: it works well with concatenated test sources, for
     clang-tidy-friendly custom unity builds. Ref: #20667
   
   Slight downside: it's not enforced.
   
   If there happens to be a collision between a local `lib/*.h` header and
   a system one, the solution is to rename (possibly with its `.c`
   counterpart) into the `curl_` namespace. This is also the method used by
   curl in the past.
   
   Also:
   - curlx/inet_pton: reduce scope of an include.
   - toolx/tool_time: apply this to an include, and update VS project
     files accordingly. Also dropping unnecessary lib/curlx header path.
   - clang-tidy: enable `readability-duplicate-include`.
   
   Follow-up to 3887069c661b40e76b053a4867eb565d4761ab3e #19676
   Follow-up to 625f2c1644da58b9617479775badea21f125ce6d #16991 #16949
   
   Closes #20623

   Changed files

   • .clang-tidy.yml
   • lib/CMakeLists.txt
   • lib/Makefile.am
   • lib/curlx/base64.c
   • lib/curlx/basename.c
   • lib/curlx/basename.h
   • lib/curlx/curlx.h
   • lib/curlx/dynbuf.c
   • lib/curlx/fopen.c
   • lib/curlx/fopen.h
   • lib/curlx/inet_ntop.c
   • lib/curlx/inet_ntop.h
   • lib/curlx/inet_pton.c
   • lib/curlx/inet_pton.h
   • lib/curlx/multibyte.c
   • lib/curlx/multibyte.h
   • lib/curlx/nonblock.c
   • lib/curlx/strcopy.c
   • lib/curlx/strdup.c
   • lib/curlx/strdup.h
   • lib/curlx/strerr.c
   • lib/curlx/strparse.c
   • lib/curlx/strparse.h
   • lib/curlx/timediff.c
   • lib/curlx/timediff.h
   • lib/curlx/timeval.c
   • lib/curlx/timeval.h
   • lib/curlx/version_win32.c
   • lib/curlx/version_win32.h
   • lib/curlx/wait.c
   • lib/curlx/wait.h
   • lib/curlx/warnless.c
   • lib/curlx/winapi.c
   • lib/vauth/cleartext.c
   • lib/vauth/cram.c
   • lib/vauth/digest.c
   • lib/vauth/digest.h
   • lib/vauth/digest_sspi.c
   • lib/vauth/gsasl.c
   • lib/vauth/krb5_gssapi.c
   • lib/vauth/krb5_sspi.c
   • lib/vauth/ntlm.c
   • lib/vauth/ntlm_sspi.c
   • lib/vauth/oauth2.c
   • lib/vauth/spnego_gssapi.c
   • lib/vauth/spnego_sspi.c
   • lib/vauth/vauth.c
   • lib/vauth/vauth.h
   • lib/vquic/curl_ngtcp2.c
   • lib/vquic/curl_ngtcp2.h
   • lib/vquic/curl_quiche.c
   • lib/vquic/curl_quiche.h
   • lib/vquic/vquic-tls.c
   • lib/vquic/vquic-tls.h
   • lib/vquic/vquic.c
   • lib/vquic/vquic.h
   • lib/vquic/vquic_int.h
   • lib/vssh/libssh.c
   • lib/vssh/libssh2.c
   • lib/vssh/ssh.h
   • lib/vssh/vssh.c
   • lib/vssh/vssh.h
   • lib/vtls/apple.c
   • lib/vtls/apple.h
   • lib/vtls/cipher_suite.c
   • lib/vtls/cipher_suite.h
   • lib/vtls/gtls.c
   • lib/vtls/gtls.h
   • lib/vtls/hostcheck.c
   • lib/vtls/hostcheck.h
   • lib/vtls/keylog.c
   • lib/vtls/keylog.h
   • lib/vtls/mbedtls.c
   • lib/vtls/mbedtls.h
   • lib/vtls/openssl.c
   • lib/vtls/openssl.h
   • lib/vtls/rustls.c
   • lib/vtls/rustls.h
   • lib/vtls/schannel.c
   • lib/vtls/schannel.h
   • lib/vtls/schannel_int.h
   • lib/vtls/schannel_verify.c
   • lib/vtls/vtls.c
   • lib/vtls/vtls.h
   • lib/vtls/vtls_int.h
   • lib/vtls/vtls_scache.c
   • lib/vtls/vtls_scache.h
   • lib/vtls/vtls_spack.c
   • lib/vtls/vtls_spack.h
   • lib/vtls/wolfssl.c
   • lib/vtls/wolfssl.h
   • lib/vtls/x509asn1.c
   • lib/vtls/x509asn1.h
   • projects/Windows/tmpl/curl.vcxproj
   • src/toolx/tool_time.c