Builder curl-ares-solaris10-i386 Build #3585
Results:
Failed runtest
SourceStamp:
Project | curl |
Repository | https://github.com/curl/curl.git |
Branch | master |
Revision | 85e18a5b9a60109d139e702c9c1028fa6ff4366e |
Got Revision | 85e18a5b9a60109d139e702c9c1028fa6ff4366e |
Changes | 11 changes |
BuildSlave:
unstable10xReason:
The SingleBranchScheduler scheduler named 'schedule-curl-ares-solaris10-i386' triggered this build
Steps and Logfiles:
Build Properties:
Name | Value | Source |
---|---|---|
branch | master | Build |
builddir | /export/home/buildbot/slave/curl-ares-solaris10-i386 | slave |
buildername | curl-ares-solaris10-i386 | Builder |
buildnumber | 3585 | Build |
codebase | Build | |
got_revision | 85e18a5b9a60109d139e702c9c1028fa6ff4366e | Git |
osplatform | I386 | SetPropertyFromCommand Step |
osrelease | 10 | SetPropertyFromCommand Step |
project | curl | Build |
repository | https://github.com/curl/curl.git | Build |
revision | 85e18a5b9a60109d139e702c9c1028fa6ff4366e | Build |
scheduler | schedule-curl-ares-solaris10-i386 | Scheduler |
slavename | unstable10x | BuildSlave |
workdir | /export/home/buildbot/slave/curl-ares-solaris10-i386 | slave (deprecated) |
Forced Build Properties:
Name | Label | Value |
---|
Responsible Users:
- Daniel Stenbergdaniel@haxx.se
- Eshan Kelkareshankelkar@galorithm.com
- Stefan Eissingstefan@eissing.org
- Viktor Szakatscommit@vsz.me
Timing:
Start | Tue Jul 29 05:45:51 2025 |
End | Tue Jul 29 20:22:41 2025 |
Elapsed | 14 hrs, 36 mins, 49 secs |
All Changes:
:
Change #241031
Category curl Changed by Viktor Szakats <commit @vsz.me>Changed at Mon 28 Jul 2025 17:29:26 Repository https://github.com/curl/curl.git Project curl Branch master Revision 975ab36531adf01970814cd81049bcc508c89c61 Comments
lib517: use `LL` 64-bit literals & re-enable a test case (`time_t`) Suffix two 64-bit `time_t` test literals with `LL` to make them compile with mingw-w64 x86_64 in C89 (the default) mode. Possibly other old gcc compilers are affected (e.g. mips gcc 4.9.4, power gcc 15.1.0), but could not pinpoint the exact rules. This also fixes a compiler warning and test failure with MSVC, allowing to re-enable a disabled test case. `LL` is not C89, but used in the code before this patch, which tells it's safe to use. Also display expected / actual timestamp values as `curl_off_t` instead of `long`, making them work with 64-bit timestamps. This was triggered by this issue seen while testing mingw-w64 gcc 4.8.1: ``` tests/libtest/lib517.c:147:5: error: this decimal constant is unsigned only in ISO C90 {"Sun, 06 Nov 2044 08:49:37 GMT", (time_t) 2362034977 }, ^ ``` Ref: https://github.com/curl/curl/actions/runs/16540378828/job/46780712313?pr=18010#step:12:32 Closes #18032
Changed files
- tests/libtest/lib517.c
Change #241032
Category curl Changed by Viktor Szakats <commit @vsz.me>Changed at Mon 28 Jul 2025 17:29:26 Repository https://github.com/curl/curl.git Project curl Branch master Revision b1df1d38afce5b2d9de3a60eacdc041c5d575498 Comments
delta: fix warnings, fix for non-GNU `date` tool It makes the script run on BSD-like envs. Follow-up to f63bdea79028c30780b3450e5d444c84b63a5434 #18058 Follow-up to 2ec54556d4e3f3ab551b5298adab0c703d85a463 #17877 Closes #18061
Changed files
- scripts/delta
Change #241033
Category curl Changed by Viktor Szakats <commit @vsz.me>Changed at Mon 28 Jul 2025 17:29:26 Repository https://github.com/curl/curl.git Project curl Branch master Revision 577ec0941235e52dcb39765c02c25444766ac2de Comments
contrithanks: fix for BSD `sed` tool Fixing on macOS, and possibly other BSDs: ``` sed: 83: ./docs/THANKS-filter: RE error: illegal byte sequence ``` Where line 83 contains `\xED`. Switch to raw encoding to avoid `sed` evaluating the stream of bytes. Ref: #18061 Closes #18062
Changed files
- scripts/contrithanks.sh
Change #241034
Category curl Changed by Viktor Szakats <commit @vsz.me>Changed at Mon 28 Jul 2025 17:29:57 Repository https://github.com/curl/curl.git Project curl Branch master Revision 81f5991e14abe71ccee22e9576dc447e8c3418f4 Comments
lib1560: replace an `int` with `bool` Follow-up to 7d1ca2e7e1a3b9d3ba70f587f6bc5e83f905afd5 #17933 Closes #18064
Changed files
- tests/libtest/lib1560.c
Change #241035
Category curl Changed by Viktor Szakats <commit @vsz.me>Changed at Mon 28 Jul 2025 17:30:36 Repository https://github.com/curl/curl.git Project curl Branch master Revision d45b85d79198a0259123923a6aa186ded2aaca6c Comments
CURLOPT: bump `CURLALTSVC_*` macros to `long` This patch bumps the size of these macros from `int` to `long`, while keeping their actual values the same. It may cause incompatibilities in user code, requiring the bump of holder variables and/or adding casts: - CURLALTSVC_H1 - CURLALTSVC_H2 - CURLALTSVC_H3 - CURLALTSVC_READONLYFILE Also: - keep existing cast within the documentation to make sure it applies to older curl versions as well. Closes #18063
Changed files
- include/curl/curl.h
Change #241036
Category curl Changed by Viktor Szakats <commit @vsz.me>Changed at Mon 28 Jul 2025 17:30:46 Repository https://github.com/curl/curl.git Project curl Branch master Revision 1a12663d06d9c42fd40a8655d5247f7afeeb8e1e Comments
CURLOPT: bump `CURLPROXY_*` enums to `long`, drop casts This patch bumps the size of these macros from `int` to `long`, while keeping their actual values the same. It may cause incompatibilities in user code, requiring the bump of holder variables and/or adding casts: - CURLPROXY_HTTP - CURLPROXY_HTTP_1_0 - CURLPROXY_HTTPS - CURLPROXY_HTTPS2 - CURLPROXY_SOCKS4 - CURLPROXY_SOCKS4A - CURLPROXY_SOCKS5 - CURLPROXY_SOCKS5_HOSTNAME Also: - keep existing cast within the documentation to make sure it applies to older curl versions as well. Closes #18054
Changed files
- include/curl/curl.h
- lib/setopt.c
- lib/url.c
- lib/urldata.h
- tests/libtest/lib1525.c
- tests/libtest/lib1526.c
- tests/libtest/lib1527.c
- tests/libtest/lib1528.c
- tests/libtest/lib1529.c
- tests/libtest/lib564.c
Change #241037
Category curl Changed by Viktor Szakats <commit @vsz.me>Changed at Mon 28 Jul 2025 17:31:33 Repository https://github.com/curl/curl.git Project curl Branch master Revision 113f6aacd4ae4eaa25fca91932013425fca3788d Comments
CURLOPT: bump `CURLHEADER_*` macros to `long`, drop casts This patch bumps the size of these macros from `int` to `long`, while keeping their actual values the same. It may cause incompatibilities in user code, requiring the bump of holder variables and/or adding casts: - CURLHEADER_SEPARATE - CURLHEADER_UNIFIED Also: - keep existing cast within the documentation to make sure it applies to older curl versions as well. Closes #18055
Changed files
- include/curl/curl.h
- tests/libtest/lib1525.c
- tests/libtest/lib1526.c
- tests/libtest/lib1527.c
- tests/libtest/lib1528.c
Change #241039
Category curl Changed by Viktor Szakats <commit @vsz.me>Changed at Mon 28 Jul 2025 17:45:04 Repository https://github.com/curl/curl.git Project curl Branch master Revision 3bb5e58c105d7be450b667858d1b8e7ae3ded555 Comments
memory: make function overrides work reliably in unity builds Fixing: - HTTPS-RR builds with c-ares and Linux MUSL. - curl-for-win minimal builds with Linux MUSL. It should fix all other kinds of entaglement between curl's redefintions of system symbols and system (or 3rd-party) headers sensitive to that. It also syncs memory override behavior between unity & non-unity builds, thus reducing build variations. The idea is to define and declare everything once in `curl_setup.h`, without overriding any system symbols with curl ones yet. Then, like before this patch, override them, if necessary, in each source file via `curl_memory.h` and `memdebug.h`, after including system headers. To ensure a clean slate with no overrides at the beginning of each source file, reset all of them unconditionally at the end of `curl_setup.h`, by including `curl_mem_undef.h`. (This assumes `curl_setup.h` is always included first, which is already the case throughout the codebase.) `curl_mem_undef.h` can also be included explicitly wherever overrides are causing problems. E.g. in tests which use unity-style builds and a previously included `curl_memory.h`/`memdebug.h` can be spilling into other source files. The simplified role of the two override headers: - `curl_memory.h`: overrides system memory allocator functions to libcurl ones, when memory tracing (aka `CURLDEBUG`) is disabled. - `memdebug.h`: overrides system memory allocator and some other functions to curl debug functions, when memory tracing is enabled. Changed made in this patch, step-by-step: - curl_memory.h: move allocator typedefs and protos to `curl_setup.h`. - memdebug.h: move `ALLOC_*` macros to `curl_setup.h`. - memdebug.h: move allocator protos to `curl_setup.h`. - memdebug.h: move `Curl_safefree()` macro to `curl_setup.h`. (it's a regular macro, with a one-time, global, definition.) - curl_memory.h: move system symbol undefs to a new, separate header: `curl_mem_undef.h`. - curl_setup.h: include `curl_mem_undef.h` at the end, unconditionally, to reset system symbol macros after each inclusion. - handle `sclose()` and `fake_sclose()` in `curl_setup.h`. They are not system symbols, a one-time definition does the job. Also: - GHA/linux: enable unity mode for the HTTP-RR c-ares MUSL job. Follow-up to 17ab4d62e62bd3bfb6dbf6cb51460629f21c03e7 #16413 That said, I'd still find it better to avoid redefining system macros. To communicate clearly the fact that they are not the original system calls and they do behave differently. And, it would allow dropping the undef/redef dance in each source file, and maintaining the logic with it. The "last #include files should be in this order" comments in each source would also become unnecessary. Also the trick of using `(func)` (or interim macros) to call the non-overridden function where required. This method works for printf and most everything else already. For `_tcsdup`, socket and fopen functions this could work without disturbing the codebase much. Ref: #16428 (clean reboot of) Closes #17827
Changed files
- .github/workflows/linux.yml
- lib/Makefile.inc
- lib/curl_mem_undef.h
- lib/curl_memory.h
- lib/curl_setup.h
- lib/curl_setup_once.h
- lib/memdebug.h
Change #241075
Category curl Changed by Eshan Kelkar <eshankelkar @galorithm.com>Changed at Mon 28 Jul 2025 22:35:39 Repository https://github.com/curl/curl.git Project curl Branch master Revision f7af8adadd51997f11eadf06c843c04feb436c3f Comments
libssh: Use sftp_aio instead of sftp_async for sftp_recv This commit replaces the usage of the old deprecated sftp_async API with the new sftp_aio API for remote file reading. Signed-off-by: Eshan Kelkar <eshankelkar@galorithm.com> Closes #17440
Changed files
- lib/vssh/libssh.c
- lib/vssh/ssh.h
Change #241076
Category curl Changed by Daniel Stenberg <daniel @haxx.se>Changed at Mon 28 Jul 2025 22:37:59 Repository https://github.com/curl/curl.git Project curl Branch master Revision 9d2075bdce1234360bd41a9146ab9b465750a840 Comments
ws: avoid NULL pointer deref in curl_ws_recv If a NULL easy handle is passed in. Pointed out by Coverity Follow-up to 960fb4924523a853d5de8f30 Closes #18065
Changed files
- lib/ws.c
Change #241080
Category curl Changed by Stefan Eissing <stefan @eissing.org>Changed at Mon 28 Jul 2025 22:57:42 Repository https://github.com/curl/curl.git Project curl Branch master Revision 85e18a5b9a60109d139e702c9c1028fa6ff4366e Comments
multi: process pending, one by one Before curl 8.14.0, when pending was a list, `process_pending_handles()` move a single transfer to processing. In 8.14.0 we changed that to move all pending transfers to processing. This lead to unwanted performance drops as reported in #18017. Restore the old behaviour. While the old behviour is better, the overall handling of "pending" transfers is not optimal, since we do not keep track of the "condition" a pending transfer is waiting on. This means, when moving a single, pending transfer, we might move one that still cannot be processed while another that could is kept pending. Since we trigger `process_pending_handles()` from various changes, the stalled pending will eventually make it to the processing queue, but this is not optimal. Fixes #18017 Reported-by: rm-rmonaghan on github Closes #18056
Changed files
- lib/multi.c